Added cancel on ESC to the ConfirmModal
#5741
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
changed the title
ESC to the ConfirmModalESC to the ConfirmModal
Luke9389
approved these changes
Oct 12, 2021
|
Actually, we might be fine to merge this now. It's not directly related to N6 but it is touching the N6 flows and will affect users who are trying out N6. What do you think @parasharrajat? |
|
Yup, I was hoping the same @Luke9389. At last, It's your call. |
parasharrajat
changed the title
ESC to the ConfirmModalESC to the ConfirmModal
parasharrajat
changed the title
ESC to the ConfirmModalESC to the ConfirmModal
|
OK go ahead and take it off hold. I think this is worth merging now. |
Luke9389
changed the title
ESC to the ConfirmModalESC to the ConfirmModal
|
OH, I suppose I can do that :) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Proposal => #5158 (comment)
I checked and verified that all ConfirmModal has a cancel handler.
Fixed Issues
$ #5158
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
output_file.mp4
Mobile Web
iOS
Android