Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output currency #5749

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix output currency #5749

merged 1 commit into from
Oct 11, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Oct 11, 2021

Details

Only full policy has outputCurrency inside value but both have it outside.

Fixed Issues

https://expensify.slack.com/archives/C020EPP9B9A/p1633790363192500

Tests

  • Go to: Settings > select a worskpace > general settings
  • Change the currency
  • Click save
  • Close the right hand modals
  • Reload page
  • Open the same general settings, check the currency shown is the one you just saved

Tested On

  • [x ] Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@iwiznia iwiznia requested a review from tgolen October 11, 2021 14:53
@iwiznia iwiznia self-assigned this Oct 11, 2021
@iwiznia iwiznia requested a review from a team as a code owner October 11, 2021 14:53
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team October 11, 2021 14:53
@iwiznia
Copy link
Contributor Author

iwiznia commented Oct 11, 2021

Oh wait, I think we need to CP staging, no? Adding that.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@tgolen tgolen merged commit da2760b into main Oct 11, 2021
@tgolen tgolen deleted the ionatan_outputcurrency branch October 11, 2021 16:36
github-actions bot pushed a commit that referenced this pull request Oct 11, 2021
Fix output currency

(cherry picked from commit da2760b)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @tgolen in version: 1.1.7-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@isagoico
Copy link

This was a pass 🎉
image

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants