Set loading to false when requestorStep is submittted #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
Set loading to false when requestorStep is submittted (cherry picked from commit 5302984)
This was referenced Oct 11, 2021
|
Tested on staging and we should be good |
|
🚀 Cherry-picked to staging by @ctkochan22 in version: 1.1.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
|
🚀 Deployed to staging by @ctkochan22 in version: 1.1.7-25 🚀
|
|
@tgolen @marcaaron @nkuoch, |
|
web |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgolen @marcaaron
We no longer set loading to false at the beginning of the callback block for
BankAccount_SetupWithdrawal(). I believe we did this because while this block completed, we sometimes show the user the previous and incorrect step before we properly render the correct step.When we moved setting loading to false here and here, we forgot to add it to the Requestor Step.
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180760
Tests / QA Steps
What we do NOT want: You can see that after submission the Beneficial Owners step flashes back
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android