-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-stag] Get CompanyAddress field to autofill and show errors #5800
[CP-stag] Get CompanyAddress field to autofill and show errors #5800
Conversation
Putting this on WIP until I've tested on all platforms |
I'll be back to this tomorrow. Gotta go |
Ok I cannot for the life of me figure out how to get rid of the line mentioned in this issue, so for now I'm gonna test this on all platforms and open up for review. |
Can we add the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
…and-error-message [CP-stag] Get CompanyAddress field to autofill and show errors (cherry picked from commit 89ebeaa)
🚀 Cherry-picked to staging by @robertjchen in version: 1.1.7-13 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
@Luke9389 I was testing this and I'm a bit confused with step 7. I think it should say |
@isagoico that is a typo, company address should be auto-filled. I went ahead and updated the OP. Can we check this one off? |
Yup my bad. That was copy pasta from the issue I made for this 😬 |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to staging by @robertjchen in version: 1.1.7-25 🚀
|
Please make sure that the dropdowns "Company type" and "Incorporation state" also display error message and their correction suggestions when no option has been selected and the form is submitted. In addition, the mandatory fields and dropdowns should be marked as required (both visually and programmatically), as mentioned in #5703 (comment) |
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Details
This PR fixes several things about the Address Picker.
This component uses a 3rd party package to populate the dropdown list for addresses. After quite a lot of wrestling we decided to just make
AddressSearch
a functional component because that seems to fix our problems immediately.Fixed Issues
$ #5794
$ https://github.com/Expensify/Expensify/issues/181023
Tests / Web QA
Error reporting
Account Number: 1111222233331111
Autofill
Account Number: 1111222233331111
b) Variant 2: Hit Submit. When you're on Step 3 (Personal Information) click the back arrow to go back to Step 2 (Company Informaion)
Tested On
Screenshots
iOS
Android