Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EnableStep Language #5826

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Update EnableStep Language #5826

merged 1 commit into from
Oct 14, 2021

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Oct 13, 2021

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180970

Tests

On dev:

  1. Add an OPEN verified bank account following SO step 3.
  2. In EnableStep.js, change const isUsingExpensifyCard = user.isUsingExpensifyCard; to const isUsingExpensifyCard = true;
  3. In ReimbursementAccountPage.js, change const currentStep = achData.currentStep || CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT; to const currentStep = CONST.BANK_ACCOUNT.STEP.ENABLE;
  4. Go to "Connect a bank account" from the workspace editor
  5. Verify the copy change

QA Steps

  1. From an account with an OPEN, verified bank account and a work email added, go to "Connect a bank account" from the workspace editor
  2. Verify the copy change

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-10-13 at 2 26 00 PM

Mobile Web

Desktop

iOS

Android

@nickmurray47 nickmurray47 self-assigned this Oct 13, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner October 13, 2021 21:29
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team October 13, 2021 21:30
@nickmurray47
Copy link
Contributor Author

Not much to review here, just a copy change. Also waiting in the issue if we want to make additional changes to this page.

Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@marcochavezf marcochavezf merged commit b9e9642 into main Oct 14, 2021
@marcochavezf marcochavezf deleted the nmurray-update-allSet branch October 14, 2021 20:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants