Added routing number validation #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify @Santhosh-Sellavel @Beamanator this impacts N6, and should not be held. |
|
@kevinksullivan Since the issue has n6-label, I put hold in title. Will remove now. |
Santhosh-Sellavel
changed the title
Santhosh-Sellavel
changed the title
|
Thanks @Santhosh-Sellavel . I went ahead and removed the label on the issue. |
Beamanator
reviewed
Oct 18, 2021
parasharrajat
suggested changes
Oct 18, 2021
|
Code looking good, but I'll re-review once iOS tests pass (probably failing due to this) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Beamanator in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Implemented the routing number validation algorithm that was confirmed here & used it to validate.
Fixed Issues
$ #5762
Tests & QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android