Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #5759 to staging 🍒 #5855

Merged
merged 3 commits into from
Oct 14, 2021
Merged

🍒 Cherry pick PR #5759 to staging 🍒 #5855

merged 3 commits into from
Oct 14, 2021

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #5759 to staging 🍒

OSBotify and others added 2 commits October 14, 2021 17:16
@OSBotify OSBotify requested a review from a team as a code owner October 14, 2021 17:16
@MelvinBot MelvinBot removed the request for review from a team October 14, 2021 17:16
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

AndrewGable
AndrewGable reviewed Oct 14, 2021
View reviewed changes
src/pages/workspace/invoices/WorkspaceInvoicesFirstSection.js Outdated
title: translate('workspace.common.invoices'),
onPress: () => openOldDotLink('reports?param={"createInvoice":true}'),
=======
title: translate('workspace.invoices.sendInvoice'),
onPress: () => openSignedInLink('reports?param={"createInvoice":true}'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openSignedInLink is not available in this CP, we will have to CP another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like openSignedInLink was removed, so I changed this back to use openOldDotLink

@roryabraham roryabraham merged commit ad917f2 into staging Oct 14, 2021
@roryabraham roryabraham deleted the AndrewGable-cherry-pick-staging-5759 branch October 14, 2021 17:46
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.7-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable left review comments

@roryabraham roryabraham roryabraham approved these changes

@marcaaron marcaaron Awaiting requested review from marcaaron

Assignees

@AndrewGable AndrewGable

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OSBotify @AndrewGable @roryabraham