Correctly exclude system emails from inviting in workspaces #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
requested changes
Oct 19, 2021
Julesssss
previously approved these changes
Oct 20, 2021
|
FYI @parasharrajat, there's a simple import conflict to resolve. |
|
@Julesssss Ready. |
parasharrajat
force-pushed
the
newWorkspaceInvite
branch
from
260f11f to
90cdb86
Compare
|
Ready for review |
marcaaron
approved these changes
Oct 20, 2021
|
Restarted the e2e test to see if it will pass |
|
No luck. Gems installation is failing. |
|
Please, Can this be merged if everything is good here? |
|
e2e test is failing do we know why? |
|
Yeah. There was some config issue which is fixed and I have merged main so they will pass shortly. |
|
@marcaaron Ready |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @marcaaron in version: 1.1.8-10 🚀
|
|
@parasharrajat @marcaaron Do we need to QA this PR? Can you please share steps |
|
No QA. thanks |
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Follow up ##4775