-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spinner on web #5955
fix: spinner on web #5955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that userNativeDriver is used in quite a few other places. Should this be applied to all references?
If this does not work with loop only and then we should only apply here. We can change the name but I feel it's fine. In future RN web will use native web animation api and thus this flag will work. |
Any idea what's going on with the failing E2E test? |
@tgolen Finally tests are passed. we are good here. |
@tgolen Ready for merge. |
It really seems like this issue was only affecting web, right @parasharrajat? I did some testing on staging and it passed QA, but like Applause testers I'm not sure how to test this on iOS native. |
Yes this only affects web. |
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Details
Fixed Issues
$ #5947
Tests | QA Steps
To test it on mobile, use the airplane mode with mobile data for steps 2 - 4.
Tested On
Screenshots
Web | Desktop | Mobile Web
output_file.mp4
iOS
Android
output_file.mp4