Add Payment Method fill when menu is active #5981
Conversation
| @@ -26,6 +26,9 @@ const propTypes = { | |||
| /** Are we loading payments from the server? */ | |||
| isLoadingPayments: PropTypes.bool, | |||
|
|
|||
| /** Is payment options in menu visible to user? */ | |||
There was a problem hiding this comment.
Any other comment suggestion here? @Beamanator
There was a problem hiding this comment.
Hmm I'd probably change this to:
| /** Is payment options in menu visible to user? */ | |
| /** Is the payment options menu open / active? */ |
There was a problem hiding this comment.
A few tiny comments, but I also think @shawnborton and I may have confused you since here we decided we want the background color to be the color when the button is "active" (darker gray) and I see in the code you're using CONST.BUTTON_STATES.ACTIVE, but that ends up giving this effect:
Screen.Recording.2021-10-22.at.11.26.30.AM.mov
Is it easy to make the background that darker gray we see when clicking on the "Add payment menu" button?
| @@ -26,6 +26,9 @@ const propTypes = { | |||
| /** Are we loading payments from the server? */ | |||
| isLoadingPayments: PropTypes.bool, | |||
|
|
|||
| /** Is payment options in menu visible to user? */ | |||
There was a problem hiding this comment.
Hmm I'd probably change this to:
| /** Is payment options in menu visible to user? */ | |
| /** Is the payment options menu open / active? */ |
|
@Beamanator We have to use
|
|
@Beamanator bump in case you missed, updated the PR. Let me know if am missing anything. |
|
Sorry for the delay @Santhosh-Sellavel - i'm back from some traveling :D will review again now! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Beamanator in version: 1.1.10-3 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀
|
Details
Add fill background to
Add Payment methodwhen payment options are active.Fixed Issues
$ #5915
Tests & QA Steps
Add Payment MethodbuttonAdd Payment Methodwill have active background fillTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android