Restrict NewDot deep/universal links to specific paths on Android #6068

Julesssss · 2021-10-26T16:56:27Z

Details

We need to restrict universal/deep-link handling to specific, supported paths. This is because the NewDot app was intercepting every web URL to open the app, but did not handle these links gracefully. For example, the N6 inbox card should open the NewDot webpage and create a new workspace automatically. The NewDot mobile app was intercepting the link but showing erros and getting stuck at the homepage.

This already works correctly for iOS, so this PR aligns Android with iOS. Restricting deep links to specific paths fixes the above issue AND aligns NewDot with OldDot.

Part 1 of a three part issue

Later on we will probably want to intercept additional URLs and handle them within the app, but this is a lot of work and not yet necessary.

Fixed Issues

https://github.com/Expensify/Expensify/issues/179366

Tests

Run these tests on Android only

Install both the NewDot (build from this branch) and OldDot (any version/environment is fine) mobile apps
Send this text as an email to yourself (ideally using Gmail)

https://expensify.com > open browser
https://expensify.com/inbox > open OldDot app
https://expensify.com/anUnhandledPath > open browser

https://new.expensify.com > open browser
https://new.expensify.com/settings > open NewDot app
https://new.expensify.com/anUnhandledPath > open browser

On mobile, open the email and tap the links, one by one
Each link should open the app or browser (this is attached to each link)
You might see the 'Which app would you like to open' prompt, which is a special case:
- If the desired outcome is 'open browser' and you have the option to open in app, this is a fail
- If the desired outcome is 'NewDot / OldDot app' and you have the option to open in both apps, this is a fail
- If the desired outcome is 'NewDot / OldDot app' and you have the option to open in app or browser, this is a success

Android
https://user-images.githubusercontent.com/10736861/139106960-22338e5e-f870-4eb7-83b6-6c54db7b3f2a.mp4

iOS
https://user-images.githubusercontent.com/10736861/139107214-69d91793-30a1-4b51-ae48-f4e2bf329636.mp4

QA Steps

Run the test steps listed above

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

^ see screencast in issue description

Android

^ see screencast in issue description

Julesssss · 2021-10-27T16:50:48Z

android/app/src/main/AndroidManifest.xml

-        </intent-filter>
-        <intent-filter>
-            <action android:name="android.intent.action.VIEW"/>
-            <category android:name="android.intent.category.DEFAULT"/>
-            <category android:name="android.intent.category.BROWSABLE"/>


We only need one intent filter for each scheme.

android/app/src/main/AndroidManifest.xml

Jag96

Looking good, just one question about the setpassword path

Jag96 · 2021-10-27T17:36:07Z

android/app/src/main/AndroidManifest.xml

        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
+
+        <!-- Custom URI handlers. Used to intercept Urban Airship deep links. -->


I was wondering if we could remove the expensify-cash scheme here, but looks like that's going to be handled in https://github.com/Expensify/Expensify/issues/176081 👍

Yeah good spot. I was going to do this separately. Thanks for the existing issue link!

android/app/src/main/AndroidManifest.xml

TomatoToaster

This LGTM, but how is this working for iOS is you're only changing AndroidManifest.xml?

Julesssss · 2021-10-28T15:30:33Z

@TomatoToaster I should have made this clearer, but iOS was already restricting the universal links which can open the app.

TomatoToaster · 2021-10-28T15:32:15Z

Sorry I saw the iOS but just now read Run these tests on Android only Merged!

OSBotify · 2021-10-28T15:32:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-10-28T21:26:00Z

🚀 Deployed to staging by @TomatoToaster in version: 1.1.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mvtglobally · 2021-10-29T00:49:56Z

@Julesssss @Jag96 @TomatoToaster Should we QA this on Android only or across all platforms? Description in test steps is referring to Android only.

Julesssss · 2021-10-29T08:47:19Z

Hi @mvtglobally, this only needs to be tested on Android. We have some follow-up PRs that will ensure the other platforms are tested.

OSBotify · 2021-10-29T22:12:55Z

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss added 4 commits October 26, 2021 16:52

remove duplicate URL deep link handler

5234246

simplify Android intent filter deep link handlers

f255f89

improve deep link documentation

293c40e

restrict universal handling to specific paths

82fd335

Julesssss self-assigned this Oct 26, 2021

Julesssss changed the title ~~Restrict NewDot deep/universal links to specific paths~~ Restrict NewDot deep/universal links to specific paths on Android Oct 27, 2021

Julesssss requested a review from a team October 27, 2021 16:38

Julesssss marked this pull request as ready for review October 27, 2021 16:38

MelvinBot requested review from Jag96 and removed request for a team October 27, 2021 16:38

Julesssss commented Oct 27, 2021

View reviewed changes

android/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

Jag96 reviewed Oct 27, 2021

View reviewed changes

Julesssss requested a review from a team as a code owner October 28, 2021 10:15

MelvinBot requested review from TomatoToaster and removed request for a team October 28, 2021 10:15

add missing 'setpassword' path, reorder to match iOS

6adaff3

Julesssss force-pushed the jules-makeDeepLinksSpecific branch from 6f0e1a2 to 6adaff3 Compare October 28, 2021 10:20

re-add removed path

c54d714

TomatoToaster approved these changes Oct 28, 2021

View reviewed changes

TomatoToaster merged commit 4525a24 into main Oct 28, 2021

TomatoToaster deleted the jules-makeDeepLinksSpecific branch October 28, 2021 15:31

OSBotify mentioned this pull request Oct 28, 2021

Deploy Checklist: New Expensify 2021-10-28 #6106

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restrict NewDot deep/universal links to specific paths on Android #6068

Restrict NewDot deep/universal links to specific paths on Android #6068

Julesssss commented Oct 26, 2021 •

edited

Loading

Julesssss Oct 27, 2021

Jag96 left a comment

Jag96 Oct 27, 2021

Julesssss Oct 28, 2021

TomatoToaster left a comment

Julesssss commented Oct 28, 2021

TomatoToaster commented Oct 28, 2021

OSBotify commented Oct 28, 2021

OSBotify commented Oct 28, 2021

mvtglobally commented Oct 29, 2021

Julesssss commented Oct 29, 2021

OSBotify commented Oct 29, 2021

Restrict NewDot deep/universal links to specific paths on Android #6068

Restrict NewDot deep/universal links to specific paths on Android #6068

Conversation

Julesssss commented Oct 26, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Julesssss Oct 27, 2021

Choose a reason for hiding this comment

Jag96 left a comment

Choose a reason for hiding this comment

Jag96 Oct 27, 2021

Choose a reason for hiding this comment

Julesssss Oct 28, 2021

Choose a reason for hiding this comment

TomatoToaster left a comment

Choose a reason for hiding this comment

Julesssss commented Oct 28, 2021

TomatoToaster commented Oct 28, 2021

OSBotify commented Oct 28, 2021

OSBotify commented Oct 28, 2021

mvtglobally commented Oct 29, 2021

Julesssss commented Oct 29, 2021

OSBotify commented Oct 29, 2021

Julesssss commented Oct 26, 2021 •

edited

Loading