Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about PR holds and potential bonuses #6073

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

Christinadobrzyn
Copy link
Contributor

based on this conversation, https://expensify.slack.com/archives/C01SKUP7QR0/p1635159599030400, adding a comment about holds and related bonuses.

Details

  • Based on this Slack conversation, the team decided to add a comment to the doc about the potential of holds and an applicable bonus.

I added a comment about this here;

image

Fixed Issues

N/A - Resolves the suggestion here - https://expensify.slack.com/archives/C01SKUP7QR0/p1635159599030400

Tests

NA

QA Steps

NA

Tested On

NA

based on this conversation, https://expensify.slack.com/archives/C01SKUP7QR0/p1635159599030400, adding a comment about holds and related bonuses.
@Christinadobrzyn Christinadobrzyn requested review from mallenexpensify and a team October 27, 2021 02:18
@MelvinBot MelvinBot requested review from deetergp and removed request for a team October 27, 2021 02:18
Copy link
Contributor

@mallenexpensify mallenexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@deetergp deetergp merged commit 4e9b6b5 into main Oct 27, 2021
@deetergp deetergp deleted the Christinadobrzyn-patch-2 branch October 27, 2021 18:37
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants