Added tooltip for the communications link #6140
Conversation
src/styles/styles.js
Outdated
| @@ -2052,6 +2052,10 @@ const styles = { | |||
| height: 20, | |||
| }, | |||
|
|
|||
| communicationsLinkText: { | |||
| width: 320, | |||
There was a problem hiding this comment.
I am strictly against using the fixed width. I would prefer to keep the app flexible (using flexbox) as much as possible.
Any special purpose for using this?
src/components/CommunicationsLink.js
Outdated
| @@ -52,7 +53,13 @@ const CommunicationsLink = props => ( | |||
| > | |||
| {props.children} | |||
| </Pressable> | |||
| ) : props.children} | |||
| ) : ( | |||
| <Tooltip text={props.value}> | |||
There was a problem hiding this comment.
Ok. It works but it takes away flexibility that comes with props.children. This tooltip should be passed with children.
There was a problem hiding this comment.
Okay got it. I'll add a separate prop for Tooltip.
There was a problem hiding this comment.
I think better would be to pass the tooltip with children
|
@parasharrajat PR updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @thienlnam in version: 1.1.13-3 🚀
|
|
Accessibility issue found in this PR:
|
Details
Fixed Issues
$ #5542
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
NA
Desktop
iOS
NA
Android
NA