Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lineHeight from baseFontStyle to stop text from flowing into links #6156

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Nov 1, 2021

@Jag96

Details

Implements @meetmangukiya's proposal here to prevent text from flowing into links on iOS.

Fixed Issues

$ #4911

Tests/QA Steps

  • Create a chat message with a long link inside of it as well as a good amount of standard text.
  • Make sure that the standard text does not flow into the link text.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-11-01 at 3 10 46 PM

Mobile Web

Screen Shot 2021-11-01 at 3 15 26 PM

Desktop

Screen Shot 2021-11-01 at 3 17 40 PM

iOS

Screen Shot 2021-11-01 at 3 14 16 PM

Android

@yuwenmemon yuwenmemon requested a review from Jag96 November 1, 2021 22:16
@yuwenmemon yuwenmemon self-assigned this Nov 1, 2021
@yuwenmemon yuwenmemon requested a review from a team as a code owner November 1, 2021 22:16
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team November 1, 2021 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well.

@Jag96
Copy link
Contributor

Jag96 commented Nov 1, 2021

Looks like there are some issues w/ Android formatting, testing to see if the issue exists on main
image

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like the Android issue is pre-existing on main, posted about it in slack

@luacmartins luacmartins merged commit 7b4a3e5 into main Nov 1, 2021
@luacmartins luacmartins deleted the yuwen-lineHeight branch November 1, 2021 23:07
github-actions bot pushed a commit that referenced this pull request Nov 1, 2021
Remove lineHeight from baseFontStyle to stop text from flowing into links

(cherry picked from commit 7b4a3e5)
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.12-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2021

🚀 Deployed to staging by @luacmartins in version: 1.1.12-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants