-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lineHeight from baseFontStyle to stop text from flowing into links #6156
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looks like the Android issue is pre-existing on main, posted about it in slack
Remove lineHeight from baseFontStyle to stop text from flowing into links (cherry picked from commit 7b4a3e5)
🚀 Cherry-picked to staging by @luacmartins in version: 1.1.12-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀
|
🚀 Deployed to staging by @luacmartins in version: 1.1.12-4 🚀
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀
|
@Jag96
Details
Implements @meetmangukiya's proposal here to prevent text from flowing into links on iOS.
Fixed Issues
$ #4911
Tests/QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android