Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix: back handler for Drawer" #6161

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Revert "Fix: back handler for Drawer" #6161

merged 1 commit into from
Nov 1, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Nov 1, 2021 •
edited by Jag96
Loading

Reverts #5745

Fixed Issues

$ #6150
$ #6147

@botify
Copy link

botify commented Nov 1, 2021

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@marcaaron marcaaron self-assigned this Nov 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron requested a review from yuwenmemon November 1, 2021 23:35
@marcaaron
Copy link
Contributor Author

Issues not reproducible in this branch - just doing a quick sanity test and seeing if main is broken again after a fresh build and cache clear then I will take off draft.

@marcaaron marcaaron marked this pull request as ready for review November 1, 2021 23:41
@marcaaron marcaaron requested a review from a team as a code owner November 1, 2021 23:41
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team November 1, 2021 23:41
TomatoToaster
TomatoToaster approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool this looks like a clean revert to me, don't block on me to merge.

Jag96
Jag96 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes #6147 as well

@yuwenmemon yuwenmemon merged commit ef05ca8 into main Nov 1, 2021
@yuwenmemon yuwenmemon deleted the revert-5745-fix-back branch November 1, 2021 23:59
github-actions bot pushed a commit that referenced this pull request Nov 2, 2021
@yuwenmemon
Merge pull request #6161 from Expensify/revert-5745-fix-back
c5255f7 
Revert "Fix: back handler for Drawer"

(cherry picked from commit ef05ca8)
This was referenced Nov 2, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.12-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.12-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@parasharrajat
Copy link
Member

Looks like two similar regressions poped out, I will try to find the cause and fix it.

@OSBotify OSBotify mentioned this pull request Nov 2, 2021
Closed
19 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2021

🚀 Deployed to staging by @yuwenmemon in version: 1.1.12-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Beamanator Beamanator mentioned this pull request Nov 4, 2021
Closed
5 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@TomatoToaster TomatoToaster TomatoToaster approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marcaaron @botify @OSBotify @parasharrajat @Jag96 @yuwenmemon @TomatoToaster