Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape the backend strings for IOU #6184

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6159

Tests | QA Steps

  1. Open staging.new.expensify.com
  2. Login with existing account
  3. Tap + button
  4. Select Split Bills
  5. Select contact with double-quote in the name
  6. Tap Request
  7. Open the chat with that IOU request and observe their name.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

@parasharrajat parasharrajat requested a review from a team as a code owner November 3, 2021 02:50
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team November 3, 2021 02:50
@parasharrajat
Copy link
Member Author

Gentle Bump @puneetlath .

@parasharrajat
Copy link
Member Author

@puneetlath Awaiting your review...

@puneetlath
Copy link
Contributor

@parasharrajat we have a merge hold right now, so won't be able to merge until next week or a little longer, but I'll review soon!

@parasharrajat
Copy link
Member Author

Maybe you can add the hold label on the issue @puneetlath. Thanks.

@mallenexpensify
Copy link
Contributor

Removed Company Offsite HOLD, feel free to merge @puneetlath

@puneetlath puneetlath merged commit c0f7b04 into Expensify:main Nov 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants