Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 1.1.13-3 on staging #6221

Merged
merged 57 commits into from
Nov 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
ebf06cb
add createAndNavigate method
marcaaron Oct 26, 2021
5ce611d
Improve methods
marcaaron Oct 26, 2021
83e6cf5
refactor shouldCreateFreePolicy method to AuthScreens class method
marcaaron Oct 27, 2021
47e90bb
fix docs
marcaaron Oct 27, 2021
c95c39c
Ensures mini actions menu will disappear when attachment modal opens up
sidferreira Oct 27, 2021
18bd48c
only update policies once
marcaaron Oct 27, 2021
7376a79
solution
marktoman Oct 27, 2021
eda9eb8
Fix new comments not re-ordering, replace deprecated componentWillRec…
marktoman Oct 30, 2021
302e018
Prevent saving the same value in Onyx
marktoman Oct 30, 2021
2a591b5
Replace the remaining use of the old draft detection
marktoman Oct 30, 2021
39b6335
Update the tests with the new draft detection
marktoman Oct 30, 2021
4bf6ca5
Added tooltip for the communications link
akshayasalvi Nov 1, 2021
84d7813
Add login validation route back in NewDot
roryabraham Nov 1, 2021
5274300
Import react
roryabraham Nov 1, 2021
ced0feb
Fix SetPassword default props
roryabraham Nov 1, 2021
b1d197a
Merge remote-tracking branch 'origin' into marcaaron-fixUpPolicyMethods
marcaaron Nov 1, 2021
51440af
make sure to return false if there is no url
marcaaron Nov 1, 2021
7a829e8
Moved tooltip to the Text component
akshayasalvi Nov 2, 2021
4e99710
remove step counter
luacmartins Nov 2, 2021
83f6cd8
change comment
luacmartins Nov 2, 2021
9eb60cc
change es copy
luacmartins Nov 2, 2021
3fdfa56
add shoulShowStepCounter prop
luacmartins Nov 2, 2021
2ae489f
add prop
luacmartins Nov 2, 2021
4ee7a86
add propType
luacmartins Nov 2, 2021
b11109e
Comply with the guidelines, minor fixes
marktoman Nov 2, 2021
0eca221
Corrected infinite loading problem if non-image file uploaded
PrashantMangukiya Nov 3, 2021
9528976
Added Spanish translation for example check image and Company types
PrashantMangukiya Nov 3, 2021
8ccf3b1
Merge pull request #6140 from akshayasalvi/tooltip-for-name
thienlnam Nov 3, 2021
fd45001
Update translation in es.js
PrashantMangukiya Nov 3, 2021
d52eef9
Refactored code within .then() block
PrashantMangukiya Nov 3, 2021
bc3e8b6
Removed trailing space to solve es lint problem.
PrashantMangukiya Nov 3, 2021
0696516
Merge branch 'main' into Rory-AddValidationLinkRouteBack
roryabraham Nov 3, 2021
f486591
Merge pull request #6189 from PrashantMangukiya/prashant-5593
thienlnam Nov 3, 2021
436d062
Fix an apostrophe to trigger a CP Build
yuwenmemon Nov 3, 2021
9fae750
Merge pull request #6191 from Expensify/yuwen-apos
roryabraham Nov 3, 2021
aafb09e
Update version to 1.1.13-1
Nov 3, 2021
d20bc9f
Merge pull request #6193 from Expensify/version-BUILD-9fae7502f5565d6…
OSBotify Nov 3, 2021
b078570
Merge pull request #6083 from sidferreira/sidferreira-5972-mini-actio…
pecanoro Nov 3, 2021
d4361a2
Improvement Payment options Padding
Santhosh-Sellavel Nov 3, 2021
0841cc4
Merge pull request #6149 from Expensify/Rory-AddValidationLinkRouteBack
roryabraham Nov 3, 2021
2281700
Merge pull request #6172 from Expensify/cmartins-removeStepCounter
Nov 3, 2021
69d01c0
Merge branch 'main' of github.com:expensify/App into pr/marktoman/6084
marktoman Nov 3, 2021
d680ff8
Merge branch 'main' of github.com:expensify/App into pr/marktoman/6084
marktoman Nov 3, 2021
dd4cd8a
Improve code style
marktoman Nov 3, 2021
dc67437
Merge pull request #6084 from marktoman/issue-6050
mountiny Nov 3, 2021
fa83e4c
Merge pull request #6196 from Santhosh-Sellavel/Improve_Payment_Optio…
deetergp Nov 4, 2021
6263d45
Update popover menu check to use isEmpty
Jag96 Nov 4, 2021
a60aa53
close Keyboard when opening drawer
parasharrajat Nov 4, 2021
fcd1dc2
Merge pull request #6080 from Expensify/marcaaron-fixUpPolicyMethods
roryabraham Nov 4, 2021
97110f0
Merge pull request #6205 from parasharrajat/keyboard-close
mountiny Nov 4, 2021
0c43cf7
Merge pull request #6190 from PrashantMangukiya/prashant-5992
Nov 4, 2021
9b9f694
Merge pull request #6201 from Expensify/joe-fix-menu-crash
roryabraham Nov 4, 2021
6df59ef
Update version to 1.1.13-2
Nov 4, 2021
18a7153
Merge pull request #6214 from Expensify/version-BUILD-9b9f6940157242e…
OSBotify Nov 4, 2021
e1ad29a
Update version to 1.1.13-3
Nov 4, 2021
fb2c1c0
Merge pull request #6220 from Expensify/version-BUILD-18a7153db75fd17…
OSBotify Nov 4, 2021
885b515
Merge branch 'main' into update-staging-from-main
Nov 4, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001011302
versionName "1.1.13-2"
versionCode 1001011303
versionName "1.1.13-3"
}
splits {
abi {
Expand Down
Binary file added assets/images/example-check-image-es.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.1.13.2</string>
<string>1.1.13.3</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.1.13.2</string>
<string>1.1.13.3</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.1.13-2",
"version": "1.1.13-3",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
1 change: 1 addition & 0 deletions src/ONYXKEYS.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export default {
REPORT_USER_IS_TYPING: 'reportUserIsTyping_',
REPORT_IOUS: 'reportIOUs_',
POLICY: 'policy_',
REPORTS_WITH_DRAFT: 'reportWithDraft_',
},

// Indicates which locale should be used
Expand Down
1 change: 1 addition & 0 deletions src/ROUTES.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export default {
REPORT_WITH_ID_DETAILS: 'r/:reportID/details',
getReportDetailsRoute: reportID => `r/${reportID}/details`,
LOGIN_WITH_SHORT_LIVED_TOKEN: 'transition',
VALIDATE_LOGIN: 'v/:accountID/:validateCode',

// This is a special validation URL that will take the user to /workspace/new after validation. This is used
// when linking users from e.com in order to share a session in this app.
Expand Down
6 changes: 5 additions & 1 deletion src/components/HeaderWithCloseButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ const propTypes = {
/** Whether we should show a inbox call button */
shouldShowInboxCallButton: PropTypes.bool,

/** Whether we should show the step counter */
shouldShowStepCounter: PropTypes.bool,

/** The task ID to associate with the call button, if we show it */
inboxCallTaskID: PropTypes.string,

Expand All @@ -57,6 +60,7 @@ const defaultProps = {
shouldShowBorderBottom: false,
shouldShowDownloadButton: false,
shouldShowInboxCallButton: false,
shouldShowStepCounter: true,
inboxCallTaskID: '',
stepCounter: null,
};
Expand Down Expand Up @@ -84,7 +88,7 @@ const HeaderWithCloseButton = props => (
)}
<Header
title={props.title}
subtitle={props.stepCounter ? props.translate('stepCounter', props.stepCounter) : ''}
subtitle={props.stepCounter && props.shouldShowStepCounter ? props.translate('stepCounter', props.stepCounter) : ''}
/>
<View style={[styles.reportOptions, styles.flexRow, styles.pr5]}>
{
Expand Down
12 changes: 11 additions & 1 deletion src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ export default {
setMyTimezoneAutomatically: 'Set my timezone automatically',
timezone: 'Timezone',
growlMessageOnSave: 'Your profile was successfully saved',
invalidFileMessage: 'Invalid file. Please try a different image.',
avatarUploadFailureMessage: 'An error occurred uploading the avatar, please try again.',
online: 'Online',
offline: 'Offline',
syncing: 'Syncing',
Expand Down Expand Up @@ -584,6 +586,14 @@ export default {
listOfRestrictedBusinesses: 'list of restricted businesses',
incorporationDatePlaceholder: 'Start date (yyyy-mm-dd)',
companyPhonePlaceholder: 'Phone Number (xxx)xxx-xxxx',
incorporationTypes: {
LLC: 'LLC',
CORPORATION: 'Corp',
PARTNERSHIP: 'Partnership',
COOPERATIVE: 'Cooperative',
SOLE_PROPRIETORSHIP: 'Sole Proprietorship',
OTHER: 'Other',
},
},
requestorStep: {
headerTitle: 'Personal information',
Expand All @@ -604,7 +614,7 @@ export default {
reviewingInfo: 'Thanks! We\'re reviewing your information, and will be in touch shortly. Please check your chat with Concierge ',
forNextSteps: ' for next steps to finish setting up your bank account.',
letsChatCTA: 'Yes, let\'s chat!',
letsChatText: 'Thanks for doing that! We have a couple more things to work out, but it’ll be easier over chat. Ready to chat?',
letsChatText: 'Thanks for doing that! We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?',
letsChatTitle: 'Let\'s chat!',
},
beneficialOwnersStep: {
Expand Down
12 changes: 11 additions & 1 deletion src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ export default {
setMyTimezoneAutomatically: 'Configura mi zona horaria automáticamente',
timezone: 'Zona horaria',
growlMessageOnSave: 'Tu perfil se ha guardado correctamente',
invalidFileMessage: 'Archivo inválido. Pruebe con una imagen diferente.',
avatarUploadFailureMessage: 'No se pudo subir el avatar. Por favor, inténtalo de nuevo.',
online: 'En línea',
offline: 'Desconectado',
syncing: 'Sincronizando',
Expand Down Expand Up @@ -586,6 +588,14 @@ export default {
listOfRestrictedBusinesses: 'lista de negocios restringidos',
incorporationDatePlaceholder: 'Fecha de inicio (aaaa-mm-dd)',
companyPhonePlaceholder: '(prefijo) + (número)',
incorporationTypes: {
LLC: 'LLC',
CORPORATION: 'Corp',
PARTNERSHIP: 'Sociedad',
COOPERATIVE: 'Cooperativa',
SOLE_PROPRIETORSHIP: 'Propietario único',
OTHER: 'Otra',
},
},
requestorStep: {
headerTitle: 'Información personal',
Expand All @@ -606,7 +616,7 @@ export default {
reviewingInfo: '¡Gracias! Estamos revisando tu información y nos comunicaremos contigo en breve. Consulte su chat con Concierge ',
forNextSteps: ' para conocer los próximos pasos para terminar de configurar su cuenta bancaria.',
letsChatCTA: '¡Sí, vamos a chatear!',
letsChatText: '¡Gracias! Todavía tenemos que solucionar un par de cosas, pero será más fácil por chat. ¿Listo para charlar?',
letsChatText: '¡Gracias! Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?',
letsChatTitle: '¡Vamos a chatear!',
},
beneficialOwnersStep: {
Expand Down
39 changes: 30 additions & 9 deletions src/libs/Navigation/AppNavigator/AuthScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import Navigation from '../Navigation';
import * as User from '../../actions/User';
import {setModalVisibility} from '../../actions/Modal';
import NameValuePair from '../../actions/NameValuePair';
import {getPolicyList} from '../../actions/Policy';
import * as Policy from '../../actions/Policy';
import modalCardStyleInterpolator from './modalCardStyleInterpolator';
import createCustomModalStackNavigator from './createCustomModalStackNavigator';
import getOperatingSystem from '../../getOperatingSystem';
Expand Down Expand Up @@ -59,6 +59,7 @@ import {
import SCREENS from '../../../SCREENS';
import Timers from '../../Timers';
import LogInWithShortLivedTokenPage from '../../../pages/LogInWithShortLivedTokenPage';
import ValidateLoginPage from '../../../pages/ValidateLoginPage';
import defaultScreenOptions from './defaultScreenOptions';
import * as API from '../../API';
import {setLocale} from '../../actions/App';
Expand Down Expand Up @@ -168,15 +169,12 @@ class AuthScreens extends React.Component {
// Load policies, maybe creating a new policy first.
Linking.getInitialURL()
.then((url) => {
// url is null on mobile unless the app was opened via a deeplink
if (url) {
const path = new URL(url).pathname;
const exitTo = new URLSearchParams(url).get('exitTo');
const shouldCreateFreePolicy = Str.startsWith(path, Str.normalizeUrl(ROUTES.LOGIN_WITH_SHORT_LIVED_TOKEN)) && exitTo === ROUTES.WORKSPACE_NEW;
getPolicyList(shouldCreateFreePolicy);
} else {
getPolicyList(false);
if (this.shouldCreateFreePolicy(url)) {
Policy.createAndGetPolicyList();
return;
}

Policy.getPolicyList();
});

// Refresh the personal details, timezone and betas every 30 minutes
Expand Down Expand Up @@ -228,6 +226,21 @@ class AuthScreens extends React.Component {
this.interval = null;
}

/**
* @param {String} [url]
* @returns {Boolean}
*/
shouldCreateFreePolicy(url = '') {
if (!url) {
return false;
}

const path = new URL(url).pathname;
const exitTo = new URLSearchParams(url).get('exitTo');
return Str.startsWith(path, Str.normalizeUrl(ROUTES.LOGIN_WITH_SHORT_LIVED_TOKEN))
&& exitTo === ROUTES.WORKSPACE_NEW;
}

render() {
const commonModalScreenOptions = {
headerShown: false,
Expand Down Expand Up @@ -274,6 +287,14 @@ class AuthScreens extends React.Component {
}}
component={MainDrawerNavigator}
/>
<RootStack.Screen
name="ValidateLogin"
options={{
headerShown: false,
title: 'New Expensify',
}}
component={ValidateLoginPage}
/>
<RootStack.Screen
name={SCREENS.LOG_IN_WITH_SHORT_LIVED_TOKEN}
options={defaultScreenOptions}
Expand Down
6 changes: 6 additions & 0 deletions src/libs/Navigation/AppNavigator/PublicScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import {createStackNavigator} from '@react-navigation/stack';
import SignInPage from '../../../pages/signin/SignInPage';
import SetPasswordPage from '../../../pages/SetPasswordPage';
import ValidateLoginPage from '../../../pages/ValidateLoginPage';
import LogInWithShortLivedTokenPage from '../../../pages/LogInWithShortLivedTokenPage';
import SCREENS from '../../../SCREENS';
import defaultScreenOptions from './defaultScreenOptions';
Expand All @@ -20,6 +21,11 @@ const PublicScreens = () => (
options={defaultScreenOptions}
component={LogInWithShortLivedTokenPage}
/>
<RootStack.Screen
name="ValidateLogin"
options={defaultScreenOptions}
component={ValidateLoginPage}
/>
<RootStack.Screen
name="SetPassword"
options={defaultScreenOptions}
Expand Down
2 changes: 2 additions & 0 deletions src/libs/Navigation/Navigation.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import _ from 'underscore';
import React from 'react';
import {Keyboard} from 'react-native';
import {
StackActions,
DrawerActions,
Expand Down Expand Up @@ -44,6 +45,7 @@ function openDrawer() {
return;
}
navigationRef.current.dispatch(DrawerActions.openDrawer());
Keyboard.dismiss();
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/libs/Navigation/linkingConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default {

// Main Routes
SetPassword: ROUTES.SET_PASSWORD_WITH_VALIDATE_CODE,
ValidateLogin: ROUTES.VALIDATE_LOGIN,
[SCREENS.LOG_IN_WITH_SHORT_LIVED_TOKEN]: ROUTES.LOGIN_WITH_SHORT_LIVED_TOKEN,

// Modal Screens
Expand Down
Loading