Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Negative margin to fix the cropped action buttons #6249

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Remove Negative margin to fix the cropped action buttons #6249

merged 3 commits into from
Nov 16, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6204

Tests | QA Steps

  1. Navigate to a conversation (make sure is with a user that shows the time zone message above compose box)
  2. Long press on a message
  3. Check the "Cancel" and "Save changes" buttons
  4. Press on cancel
  5. Check the message

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-11-05 22:38:31

iOS

Android

output_file.mp4

@parasharrajat
Remove Negative margin to adjust the UI
d7690eb 
Edit Message Action buttons were getting cropped due to this.
@parasharrajat parasharrajat requested a review from a team as a code owner November 5, 2021 17:13
@MelvinBot MelvinBot requested review from timszot and removed request for a team November 5, 2021 17:13
timszot
timszot approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 16, 2021 •
edited
Loading

Should be good to merge now @timszot Hold is lifted.

@timszot timszot merged commit 239e326 into Expensify:main Nov 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @timszot in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 29, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timszot timszot timszot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @timszot