Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank screen displayed on Company Step VBA flow #6327

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 16, 2021

Details

Removes bad usages of <div> from Company Step

cc @AndrewGable @Gonals

Fixed Issues

$ #6322

Tests

  1. Log in to NewDot
  2. Go to any Worksplace
  3. Tap Connect bank account
  4. Tap Continue
  5. Choose the Chase Bank account
  6. Put username: user_good, password:pass_good
  7. Select Saving bank account
  8. Tap Save and Continue
  9. Verify the app does not crash

QA Steps

Same as above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Nov 16, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@luacmartins luacmartins requested a review from a team November 16, 2021 18:14
@luacmartins luacmartins marked this pull request as ready for review November 16, 2021 18:14
@MelvinBot MelvinBot requested review from francoisl and removed request for a team November 16, 2021 18:14
@luacmartins luacmartins changed the title Blank screen displayed after select Plaid Saving account for VBA flow Fix blank screen displayed on Company Step VBA flow Nov 16, 2021
@luacmartins luacmartins merged commit 84a6ee8 into main Nov 16, 2021
@luacmartins luacmartins deleted the cmartins-removeDivs branch November 16, 2021 18:36
@luacmartins
Copy link
Contributor Author

Self-merged after tests passed.

github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
Fix blank screen displayed on Company Step VBA flow

(cherry picked from commit 84a6ee8)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.15-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@Gonals
Copy link
Contributor

Gonals commented Nov 17, 2021

Hmm. Not sure how this got through the cracks 🤔. I created a PR to fix it as soon as the original merged, but someone else had already fix it when it got to merge time! Maybe we reverted or something 🤷

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants