-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update webpack path for apple app association #6408
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
|
Will you also fix the error, from here
in this PR? Edit: NVM me it looks like the most recent actions are passing just fine on this. |
[No QA] Update webpack path for apple app association (cherry picked from commit 6b34f86)
🚀 Cherry-picked to staging by @Jag96 in version: 1.1.16-1 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
|
Details
This fixes the path for the apple-app-association file in webpack, which is causing GH actions failures on desktop
Fixed Issues
Related to #6385
Tests
Run
npm run desktop-build
locally and confirm no errors happen.QA
None
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android