Prevent cannot read property of undefined for href.startsWith #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
69 tasks
|
🚀 Deployed to staging by @luacmartins in version: 1.1.16-11 🚀
|
|
The accessibility issues mentioned in #6392 (comment) are applicable to this PR as well. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/185343
Tests
Same as QA steps. I only managed to reproduce the bug by hardcoding an undefined href, then made sure that without the fix, I got the blank page like in the original issue, and that my changes fixed it.
QA Steps
Tested On