Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode oldDot links with param in the URL #6485

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 25, 2021

Details

Encode OldDot urls with param so we are already logged in when redirected.

Fixed Issues

$ #6484

Tests

  1. Log into an account with the Expensify Card enabled.
  2. Select a workspace and navigate to Issue corporate cards.
  3. Click on Reconcile cards and verify that an OldDot page opens and you are logged in.
  4. Perform steps 2-3 but this time in Send invoices > Send invoice

QA Steps

  1. Log into an account with the Expensify Card enabled.
  2. Select a workspace and navigate to Issue corporate cards.
  3. Click on Reconcile cards and verify that an OldDot page opens and you are logged in.
  4. Perform steps 2-3 but this time in Send invoices > Send invoice

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins requested a review from a team as a code owner November 25, 2021 23:06
@luacmartins luacmartins self-assigned this Nov 25, 2021
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team November 25, 2021 23:06
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins
Copy link
Contributor Author

Self-merging with approval.

@luacmartins luacmartins merged commit d2eadd4 into main Nov 26, 2021
@luacmartins luacmartins deleted the cmartins-fixOldDotLinks branch November 26, 2021 16:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants