Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: scroll issue for workspace pages #6543

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Nov 30, 2021

Details

Fixed Issues

$ #6496

Tests | QA Steps

  1. Navigate to workspace settings
  2. Change the orientation to landscape
  3. Click on any of the options.
  4. Scroll the page.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

iOS

Android

output_file.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner November 30, 2021 19:08
@MelvinBot MelvinBot requested review from Gonals and removed request for a team November 30, 2021 19:08
@Gonals Gonals merged commit c2b96c1 into Expensify:main Dec 1, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat
Copy link
Member Author

@Gonals Unfortunately, I missed two pages. I am sending a follow-up PR.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @Gonals in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants