-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Terms and Fees step to match latest requirements #6573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good! I forget where we landed with this general UX discussion, but should we actually move the green button to be at the very bottom of the disclosure text instead of being fixed to the bottom of the viewport? I think that makes sense given that you basically need to scroll all the way to the bottom and tap on the checkboxes before moving forward. Thoughts on that? |
Good find, I'll have a look
Yes, I'll update! |
Fixed the error message and button and added some spacing under the button as well, screenshots have been updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @MonilBhavsar in version: 1.1.18-4 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
cc @shawnborton for design 👀
Details
This PR updates the styles for the Terms and Fees step of the VBA flow based on the mockups in https://github.com/Expensify/Expensify/issues/167278#issuecomment-982972716.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/167278
Tests
The easiest way to get to the Terms Page without going through the entire OnFido flow is to update the following lines locally:
+
button and selectingNew Chat
QA Steps
No QA
Tested On
Screenshots