Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Old password when user click goBack #6723

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Dec 12, 2021

Details

Follow up PR of #5275 to SignInPage.

Tests |QA Steps

  1. Go to the login page.
  2. Add an email manually.
  3. Press continue and add password on the next page manually.
  4. Click Go back.
  5. Add the email again.
  6. Click continue and confirm that there is no password on the next page.
  7. Click go back.
  8. Select an email from the password Manager.
  9. Confirm that email is autofill.
    10 click continue and confirm that there is a password auto-filled for that email.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner December 12, 2021 18:11
@MelvinBot MelvinBot requested review from mountiny and removed request for a team December 12, 2021 18:11
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🚢

@mountiny mountiny merged commit 2ecdbbc into Expensify:main Dec 12, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.20-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@parasharrajat,
What password manager should we use to validate Desktop? We are able to test Web and mWeb, but not sure how to trigger it for Desktop app.

@parasharrajat
Copy link
Member Author

parasharrajat commented Dec 16, 2021

It's fine, you don't need to test it on the Desktop @mvtglobally . If it is working on the web, we can safely assume it works on Desktop too.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@fedirjh fedirjh mentioned this pull request Jun 14, 2023
57 tasks
@parasharrajat parasharrajat deleted the loginform branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants