-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoCapitalize prop to avoid first letter duplication on android #6916
Add autoCapitalize prop to avoid first letter duplication on android #6916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parasharrajat Now I am not sure how our linter is set up, but will it not throw error in case we do not define the the props? If that is not a problem, I agree with removing the props.
Yeah, @mountiny. It won't throw an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Cc: @mountiny
Thanks, @parasharrajat! You were right, I didn't need to specify the props, I tested it and it works fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I missed that. Could you please sign all the commits and we should be able to see your username for the signed GPG key.
Oops, I forgot about that. Would you recommend just doing a fresh new branch/PR? or try to amend the commits to add the signature? |
You can just force push and rebase the commits. That should be less time-consuming. |
Add autoCapitalize value none for WorkspaceNewRoomPage
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
Co-authored-by: Rajat Parashar <[email protected]>
eca8bb0
to
a79ad5b
Compare
Done! Thanks @parasharrajat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for such a great cooperation! Thank you @CamilaRivera for this fix 🙌
Merging
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Details
Add
autoCapitalize
prop forTextInputWithPrefix
andTextInputWithLabel
(drill)Pass
autoCapitalize="none"
prop toTextInputWithLabel
in WorkspaceNewRoomPageFixed Issues
$ #6725
Tests | QA Steps
Expected result: You should not get the first letter duplicated
Tested On
Screenshots
Web
Screen.Recording.2021-12-28.at.8.39.09.PM.mov
Mobile Web
Desktop
iOS
Screen.Recording.2021-12-28.at.8.37.55.PM.mov
Android
XRecorder_Edited_28122021_122837.mp4