Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] fix: Added translate key for street name based on the form #6930

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[No QA] fix: Added translate key for street name based on the form #6930

merged 1 commit into from
Dec 29, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Dec 29, 2021 •
edited
Loading

Details

Fixed Issues

$ #6928

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mananjadhav mananjadhav requested a review from a team as a code owner December 29, 2021 16:31
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team December 29, 2021 16:32
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@aldo-expensify aldo-expensify self-requested a review December 29, 2021 16:55
aldo-expensify
aldo-expensify approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works well, I'll merge after E2E tests.

@aldo-expensify aldo-expensify merged commit 26c0c2e into Expensify:main Dec 29, 2021
OSBotify pushed a commit that referenced this pull request Dec 29, 2021
@aldo-expensify @OSBotify
Merge pull request #6930 from mananjadhav/fix/street-placeholder
009be76 
[No QA] fix: Added translate key for street name based on the form

(cherry picked from commit 26c0c2e)
@OSBotify OSBotify mentioned this pull request Dec 29, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @aldo-expensify in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify OSBotify mentioned this pull request Jan 4, 2022
Closed
45 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47 nickmurray47 approved these changes

@aldo-expensify aldo-expensify aldo-expensify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mananjadhav @OSBotify @nickmurray47 @aldo-expensify