Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add checkbox to PR template so that reviewers/testers remember to check for console errors #7031

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jan 4, 2022

Details

Require checking for console errors in the Pull Request template

Fixed Issues

https://expensify.slack.com/archives/C01GTK53T8Q/p1641334718044700?thread_ts=1641334519.042500&cid=C01GTK53T8Q

Tests

  • Verify that no errors appear in the JS console

QA Steps

  • Verify that no errors appear in the JS console

Tested On

N/A

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Jan 4, 2022
@marcaaron marcaaron changed the title [No QA] Add checkbox to PR template so that reviewers and testers remember to check for console errors [No QA] Add checkbox to PR template so that reviewers/testers remember to check for console errors Jan 4, 2022
@marcaaron marcaaron marked this pull request as ready for review January 6, 2022 19:10
@marcaaron marcaaron requested a review from a team as a code owner January 6, 2022 19:10
@MelvinBot MelvinBot requested review from flodnv and removed request for a team January 6, 2022 19:10
@Jag96 Jag96 merged commit 7a4354b into main Jan 6, 2022
@Jag96 Jag96 deleted the marcaaron-addRuleAboutVerifyingNoConsoleErrors branch January 6, 2022 19:14
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.26-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.27-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants