Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Only use isPullRequestMergeable action after PR is approved #7044

Merged
merged 1 commit into from
Jan 5, 2022
Merged

[No QA] Only use isPullRequestMergeable action after PR is approved #7044

merged 1 commit into from
Jan 5, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Only use the isPullRequestMergeable action after a PR is approved.

Fixed Issues

https://expensify.slack.com/archives/C03V9A4TB/p1641415688476900

Tests

  1. Merge this PR
  2. Re-run the production deploy and see if it works.

QA Steps

None

@roryabraham roryabraham self-assigned this Jan 5, 2022
@roryabraham roryabraham requested a review from a team as a code owner January 5, 2022 21:10
@roryabraham roryabraham requested a review from francoisl January 5, 2022 21:10
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Gonals and removed request for a team January 5, 2022 21:10
@AndrewGable AndrewGable merged commit a88614c into main Jan 5, 2022
@AndrewGable AndrewGable deleted the Rory-IsPullRequestMergeable branch January 5, 2022 22:11
OSBotify pushed a commit that referenced this pull request Jan 5, 2022
@AndrewGable @OSBotify
Merge pull request #7044 from Expensify/Rory-IsPullRequestMergeable
8a9a6c8 
[No QA] Only use isPullRequestMergeable action after PR is approved

(cherry picked from commit a88614c)
@OSBotify OSBotify mentioned this pull request Jan 5, 2022
Merged
@francoisl francoisl mentioned this pull request Jan 5, 2022
Closed
45 tasks
@OSBotify OSBotify mentioned this pull request Jan 5, 2022
Closed
21 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2022

🚀 Deployed to staging by @AndrewGable in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@AndrewGable AndrewGable AndrewGable approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @francoisl @AndrewGable