Allow us to properly see 0 members in a policy room details #7065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TomatoToaster
requested review from
francoisl and
a team
and removed request for
jasperhuangg
francoisl
reviewed
Jan 6, 2022
TomatoToaster
force-pushed
the
amal-fix-empty-members-ucpr
branch
from
7fc4640 to
07554c2
Compare
francoisl
approved these changes
Jan 6, 2022
OSBotify
pushed a commit
that referenced
this pull request
Jan 6, 2022
Allow us to properly see 0 members in a policy room details (cherry picked from commit f88ec35)
21 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @francoisl
Details
Fixes an issue that causes User Created Policy Rooms to crash on iOS. When there are 0 other members in a policyRoom, it crashes because this
0 && anything = 0instead offalseorundefined. This causes iOS to crash when rendering that0value. Since the subtitle can be of type number, I think we should allow the value to be 0.When policyRooms have 0 members (i.e you're the only person in them), we still want them to show up in reportDetails.
Fixed Issues
$ #7055
Tests / QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android