-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy rooms to its own beta, and restrict this beta on dev #7130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this will work. We could also do something about filtering out the policy rooms from LHN and search too.
NAB: Not sure how to tag this in the review, but could you add a line similar to here:
I don't think we need to keep the |
Cool and I verified on production, normal accounts don't have the "all" beta enabled by default while expensifail accounts do. Contributors should stop seeing these now but QA and Expensifiers should still be able to. |
@TomatoToaster Thanks so much for verifying :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm weird GH quirk removed my stale review I think
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @jasperhuangg in version: 1.1.27-2 🚀
|
🚀 Deployed to staging by @jasperhuangg in version: 1.1.27-3 🚀
|
🚀 Deployed to staging by @jasperhuangg in version: 1.1.27-3 🚀
|
Details
This restricts the usage of policy rooms to those behind the beta on dev. This includes creating policy rooms via the global create menu, and accessing them in the LHN.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/191754
Tests/QA
N/A
Screenshots
Web
Mobile Web
Desktop
iOS
Android