Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the 💳 Payment Method on the PaymentMethod list when its menu is active #7374

Merged
merged 7 commits into from
Jan 26, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 25, 2022

Details

Fixed Issues

$ #7353

Tests | QA Steps

  1. Open PaymentsPage .
  2. Click any payment method.
  3. It should be highlighted when menu is open for it.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web

image

iOS

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner January 25, 2022 01:53
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team January 25, 2022 01:53
@parasharrajat
Copy link
Member Author

Updated.

@marcochavezf marcochavezf merged commit 45f5e38 into Expensify:main Jan 26, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @marcochavezf in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants