Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import to fix lint error #7406

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Remove import to fix lint error #7406

merged 1 commit into from
Jan 25, 2022

Conversation

AndrewGable
Copy link
Contributor

Details

Fix lint error:

andrew ➜ (main) App npm run lint

> [email protected] lint /Users/andrew/Expensidev/App
> eslint . --max-warnings=0


Error while parsing /Users/andrew/Expensidev/App/src/libs/actions/Report.js
Line 29, column 13: Line 29: Identifier 'OptionsListUtils' has already been declared

  27 | import Growl from '../Growl';
  28 | import * as Localize from '../Localize';
> 29 | import * as OptionsListUtils from '../OptionsListUtils';
     |             ^
  30 |
  31 | let currentUserEmail;
  32 | let currentUserAccountID;
`parseForESLint` from parser `/Users/andrew/Expensidev/App/node_modules/babel-eslint/lib/index.js` is invalid and will just be ignored

/Users/andrew/Expensidev/App/src/libs/actions/Report.js
  29:13  error  Parsing error: Identifier 'OptionsListUtils' has already been declared

  1 Remove import to fix lint error
  27 | import Growl from '../Growl';
  28 | import * as Localize from '../Localize';
> 29 | import * as OptionsListUtils from '../OptionsListUtils';
     |             ^
  30 |
  31 | let currentUserEmail;
  32 | let currentUserAccountID;

✖ 1 problem (1 error, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] lint: `eslint . --max-warnings=0`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/andrew/.npm/_logs/2022-01-25T23_23_36_924Z-debug.log

Tests

  1. Run npm lint or check the lint action

@AndrewGable AndrewGable self-assigned this Jan 25, 2022
@AndrewGable AndrewGable requested a review from a team as a code owner January 25, 2022 23:25
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team January 25, 2022 23:26
@roryabraham
Copy link
Contributor

roryabraham commented Jan 25, 2022

CPing this to staging to un-block deploys. It's not an emergency, but there's also no need to wait since this just fixes a lint error.

@roryabraham roryabraham merged commit c67e096 into main Jan 25, 2022
@roryabraham roryabraham deleted the andrew-lint-main branch January 25, 2022 23:57
@botify
Copy link

botify commented Jan 25, 2022

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

OSBotify pushed a commit that referenced this pull request Jan 26, 2022
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.33-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants