Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show IOU number pad on all touch devices #7423

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

parasharrajat
Copy link
Member

Details

#7329 (comment)

Fixed Issues

$ #7329

Tests | QA Steps

  1. Launch the app and Log in to any account
  2. On a conversation, click on the + button in the compose box
  3. Choose "Request Money" or "Send money"
  4. Confirm that BigNumberpad is visible on Mobile Web, Android, IOS, iPad, Android Tablet but not of web and Desktop unless those have touch screens.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner January 26, 2022 17:03
@MelvinBot MelvinBot requested review from tgolen and removed request for a team January 26, 2022 17:03
@tgolen tgolen merged commit dacb363 into Expensify:main Jan 27, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @tgolen in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants