Delete bank account key from bankAccountList

[luacmartins]

Details

We never delete the bankAccountID key from the bankAccountList object, we just set the value to null here. We end up getting errors when looping over the object and trying to access properties on null - e.g. here and here.

Fixed Issues

$ #7391

Tests

1. Log into the app
2. Go to any Workspace and click Connect bank account
3. Select Connect online with Plaid
4. Use the info in this SO to add an OPEN bank account.
5. After Bank connected successfully click on Disconnect bank account
6. Verify that there is no error and the bank account is deleted.

• Verify that no errors appear in the JS console

QA Steps

Steps above.

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

[Julesssss]

Hi @luacmartins, I don't think that this is due to your PR, but I am getting redirected to the Routing number / Account number step when trying to add an open account via Plaid 😕

Did you happen to see this during testing? I see it on both main and cmartins-deleteAccountFromBankAccountList. I have updated all repos too. I shared in Slack here for more help.

PlaidRedirect.mov

[luacmartins]

I don't recall seeing that particular redirect, but I had some issues with the flow where I wasn't seeing the savings account option - https://expensify.slack.com/archives/C01GTK53T8Q/p1643906776673469

[Julesssss]

Hmm, I'm still having problems after rebuilding the vm, and I'm not seeing any logs which stand out to me. I'm not sure what else to try at this point. I might need to reprovision as a last resort.

[Julesssss]

I reprovisioned today, created a new account, but I see the same issue 😞

[luacmartins]

I updated my repos today and also saw the redirect when selecting Chase. However, it works if I select Wells Fargo. Maybe it's related to Nick's comment.

[Julesssss]

Alright, sorry for the delay here. Until today I thought the only Plaid staging bank that worked was Chase!

It worked flawlessly on web and mobile once I tested with an open Wells Fargo bank 👍

[luacmartins]

No worries! Thanks for raising this issue! I updated the SO from Chase to Wells Fargo!

[luacmartins]

Self-merging with approval!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @luacmartins in version: 1.1.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅