Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoQA] Update the comments for getTooltipShiftX #7593

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[NoQA] Update the comments for getTooltipShiftX #7593

merged 1 commit into from
Feb 7, 2022

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Feb 6, 2022

Details

Just a simple change to comments to fix some typos and make it easier to read and understand.

Fixed Issues

N/A

Tests

  • Verify that no errors appear in the JS console

QA Steps

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@mountiny mountiny self-assigned this Feb 6, 2022
@mountiny mountiny requested a review from a team as a code owner February 6, 2022 19:22
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team February 6, 2022 19:23
yuwenmemon
yuwenmemon approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. 😄

@yuwenmemon yuwenmemon merged commit 0335591 into main Feb 7, 2022
@yuwenmemon yuwenmemon deleted the vit-updateTooltipShiftComment branch February 7, 2022 20:06
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 9, 2022
Closed
49 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @yuwenmemon in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mountiny @OSBotify @yuwenmemon