Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add guidance for boolean props and variables #7611

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

marcaaron
Copy link
Contributor

Details

This is pretty universally applied in our app, but not always clear to people.

Fixed Issues

No issue

Tests

@marcaaron marcaaron requested a review from a team as a code owner February 7, 2022 21:18
@marcaaron marcaaron self-assigned this Feb 7, 2022
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team February 7, 2022 21:18
@marcaaron marcaaron mentioned this pull request Feb 7, 2022
11 tasks
@nkuoch nkuoch merged commit aec9e14 into main Feb 8, 2022
@nkuoch nkuoch deleted the marcaaron-booleanProps branch February 8, 2022 10:13
@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @nkuoch in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants