[Transfer Balance] Don't force account selection when there is only one option

[marcaaron]

Details

Fixed Issues (Related to)

#7613

Tests

1. Add a valid bank account AND debit card payment method via New Dot
2. Make sure there are only one of each
3. Navigate to the Transfer Balance page and toggle back and forth between debit and bank options
4. Verify the selection screen does not appear because it is not necessary
5. Add another payment method (fund) and verify that the selection screen pops up when there's more than one debit card
6. Add another payment method (bank) and verify that the selection screen pops up when there's more than one bank account
   https://user-images.githubusercontent.com/32969087/152886420-b16b96f6-a6d8-4be3-8cd2-7164bf185262.mp4

• Verify that no errors appear in the JS console

QA Steps

Same as tests

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[bondydaa]

just one small commenting to clarify i remember javascript properly 😅 . going to tag stites in here too since he's worked on this stuff as well.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @stitesExpensify in version: 1.1.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

@marcaaron @bondydaa @stitesExpensify Will this PR require fully verified PROD KYC account?
It may need to be internal as we are not able to QA Transfer Balance properly with test data

[stitesExpensify]

I don't think so since you don't actually have to transfer the funds. You just need the ability to add accounts

[marcaaron]

The Transfer Balance page should be available and payment methods can be added. Getting through the Onfido flow successfully and successfully transferring a balance are not necessary steps.

[isagoico]

@marcaaron We are still blocked from testing this since we need a account with the upgraded wallet status (this thread https://expensify.slack.com/archives/C01GTK53T8Q/p1644261558763339?thread_ts=1643563169.531119&cid=C01GTK53T8Q and this ticket https://github.com/Expensify/Expensify/issues/195344 are addressing this problem) Most of our testers are not located in the US so the Onfido process takes longer and most of them are stuck on this page

If you can provide an account with this status enabled we can definitely test this PR.

[marcaaron]

Thank @isagoico, but why is an upgraded wallet necessary to test this? Which step are you getting stuck on?

[isagoico]

what we did was:

1. Add a BBA account
2. Add a test debit card
3. Navigate to payments and click on transfer balance
4. Onfido is prompted. Finish the flow.

After Onfido is finished, we get this modal.

Recording.392.mp4

[marcaaron]

Ah SO sorry, I forgot we added the KYC wall there. I just tested this on staging with some credentials it's working fine and can be checked off.

[marcaaron]

There are a couple of follow up things I noticed...

1. When deleting a Debit Card the list of payments doesn't refresh
2. Default payments are still not defaulted to (someone is working on this already)

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅