-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: reset the wallet balance when transfer is successful #7681
Conversation
@parasharrajat please include steps for how to get a non-zero balance as well so that this can be tested using a fresh account |
@NikkiWines I have added the testing steps. I don't know the way to load the wallet. |
Thank you!
No worries, I would just add a step 1 for QA steps that they should log into an account with a non-zero wallet balance. |
If possible, I do think it's good to attach clips of the tests for mweb, android, ios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Just missing some screenshots, will approve once those are added
I have added the test clips for web| Desktop| Mobile web. I can't open the transfer page directly on Android| IOS due to KYCWall. But I think they are not needed. The change is small and clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @NikkiWines in version: 1.1.39-0 🚀
|
@NikkiWines We are not able to QA Transfer Balance functionality due ty KYC wall. Can you validate this internally? |
Asking @joekaufmanexpensify since it looks like his account is the one being used in the video shown in the issue |
My balance was already transferred, but sent Nikki $1 to validate that this works when attempting a balance transfer. |
Confirms the fix works as anticipated 🎉 Ty @joekaufmanexpensify for the help! Screen.Recording.2022-02-15.at.14.55.04.mov |
Details
Fixed Issues
$ #7626
Tests | QA Steps
To test locally
Tested On
Screenshots
Web | Desktop
screen-2022-02-13_01.36.41.mp4
Mobile Web
screen-2022-02-13_01.34.08.mp4
iOS
Android