-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TextInputWithFocusStyles
with TextInput
#7721
Refactor TextInputWithFocusStyles
with TextInput
#7721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puneetlath LGTM! Tests well on all platforms
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @puneetlath in version: 1.1.40-0 🚀
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
Issue 1 - Title- [Medium]: Chrome+ Jaws : Screen reader : Role is not defined for 'Indian Rupee sign icon' control. 7721_Not.reading.the.role.for.the.icon.mp4Issue 2 - Title- [Medium]: Chrome+ Jaws : Screen reader : Screen reader is not provide information about the search result . 7721_Not.provide.the.search.result.information.mp4Issue 3 - Title- [High]: Safari + Voiceover : Keyboard : 'Indian rupees icon' control is not accessible using Swipe gesture. 7721_Rupees.icon.is.not.accessible.using.swipe.gesture.mp4 |
Details
TextInputWithFocusStyles
Purpose of component
Remove the extra component and use TextInput instead.
Fixed Issues
$ #6584
$ #7309
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
Android