Add the Expensify CPA Card to the NewDot homepage and redirect to use dot #7771
Conversation
|
Great work, thank you! Is it possible to make the UseDot page open in a new tab? I just don't want people to be pulled away from logging in if that's what they came here to do :) |
|
Yep, its already doing that. I can read your mind |
|
@ctkochan22 You need to test this in all platforms, you can also get the background page on Dekstop. |
|
Ah right |
| @@ -4,6 +4,7 @@ import ENVIRONMENT from './ENVIRONMENT'; | |||
| import * as Url from '../libs/Url'; | |||
|
|
|||
| const CLOUDFRONT_URL = 'https://d2k5nsl2zxldvw.cloudfront.net'; | |||
| const USE_EXPENSIFY_URL = 'https://use.expensify.com'; | |||
ctkochan22
changed the title
ctkochan22
changed the title
|
Is the background color "ivory" In the cc @shawnborton |
|
Also updated! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
In the future, can we make sure to get sign off from Design before merging these kinds of changes? It looks like the homepage image can get too close to the edges of the container here: @ctkochan22 where did you get the image you are using for the background? |
|
@shawnborton oh you actually bring an interesting problem, there is actually no process for that and we merged because all reviewers approved it. I actually think we should bring this up in engineering to come up with a process where we ensure the design team has reviewed these changes before merging, like some kind of pullerBear for design when things deal with CSS or design content. |
|
Ah, I could have sworn adding Design to a PR in this repo would automatically assign a Designer? |
|
Maybe it only works with issues and not PRs? |
|
Ah thats my bad, it seemed like the design aspect was flushed out. But I should have assigned one of yall to be sure |
|
Yeah adding the design label works for the issue, not the PR |
|
I just checked this off on the deploy checklist 👍 |
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
| { | ||
| backgroundColor: colors.floralwhite, | ||
| backgroundImageUri: `${CONST.CLOUDFRONT_URL}/images/homepage/brand-stories/cpa-card.svg`, | ||
| redirectUri: `${CONST.USE_EXPENSIFY_URL}/accountants`, |
There was a problem hiding this comment.
Hi! 👋 Coming in super late, but I noticed this and StyleUtils should only be returning things that are styles. This URL is used only for redirecting the user so it should not be returned from the styles. @ctkochan22 can you please fix this so that Link.openExternalLink(backgroundStyle.redirectUri); uses ${CONST.USE_EXPENSIFY_URL}/accountants directly?
@Expensify/pullerbear
cc @TomatoToaster @jamesdeanexpensify
Details
It adds the CPA card to the login promo rotation, and it allows users to click the image and it'll redirect to the CPA page on use dot
WEB
DESKTOP
IPAD
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/196589
Tests / QA Steps
use.expensify.com/accountantsTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android