Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label for Close account login field #7783

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Feb 16, 2022

Details

Fixed Issues

$ #7379

Tests | QA Steps

  1. Open Settings page.
  2. Go to Security > Close account page.
  3. Check if the label of the enter your primary login is not overflowing.
  4. Primary login is visible over the field.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@parasharrajat parasharrajat marked this pull request as ready for review February 24, 2022 22:28
@parasharrajat parasharrajat requested a review from a team as a code owner February 24, 2022 22:28
@botify botify requested a review from AndrewGable February 24, 2022 22:28
@MelvinBot MelvinBot removed the request for review from a team February 24, 2022 22:28
@AndrewGable AndrewGable merged commit d8ee834 into Expensify:main Feb 25, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to staging by @AndrewGable in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2022

🚀 Deployed to staging by @AndrewGable in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Stutikuls
Copy link

Stutikuls commented Mar 14, 2022

Issue1 -

Title- [Medium]: Chrome : Color Contrast : Color contrast ratio fail for 'Close (X) and back (<)' controls.
Actual - Color contrast ratio 1.7:1 for 'Close (X) and back (<)' controls.
Note - This issue repro on the whole Expensify screens.
Expected - Color contrast ratio should 3.0:1 for 'Close (X) and back (<)' controls.
WCAG failure - 1.4.11
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Desktop (MAC), Web(Chrome), Mobile-web(iOS), iOS, Android

7783_CCa fail for Back and Close controls

Issue 2 -

Title- [Medium]: Chrome : Color Contrast : Color contrast ratio fail for 'Placeholder' text.
Actual - Color contrast ratio 3.4:1 for 'Placeholder' text.
Expected - Color contrast ratio should 4.5:1 for 'Placeholder' text.
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Desktop (MAC), Web(Chrome), Mobile-web(iOS), iOS, Android

7783_CCA fail for placeholder text

Issue 3 -

Title- [Medium]: Chrome : Color Contrast : Color contrast ratio fail for 'Edges' of the text box.
Actual - Color contrast ratio 1.2:1 for 'Edges' of the text box.
Expected - Color contrast ratio should 3.0:1 for 'Edges' of the text box.
WCAG failure - 1.4.11
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Desktop (MAC), Web(Chrome), Mobile-web(iOS), iOS, Android

7783_CCA fail for Edges of the text boxes

@parasharrajat parasharrajat deleted the closeAcountPage branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants