Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add informative text for visibility settings #7876

Merged
merged 2 commits into from
Mar 1, 2022
Merged

add informative text for visibility settings #7876

merged 2 commits into from
Mar 1, 2022

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Feb 23, 2022

Details

Added informative text for visibiilty settings in New Room page

Fixed Issues

$ #7669

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Click "+"
  2. Click "New Room"
  3. Check that there is some informative text below the Visibility settings
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-02-23.at.7.47.36.PM.mov

Mobile Web

Screen.Recording.2022-02-23.at.7.56.28.PM.mov

Desktop

Screen.Recording.2022-02-23.at.7.51.48.PM.mov

iOS

Screen.Recording.2022-02-23.at.8.05.36.PM.mov

Android

Screen.Recording.2022-02-23.at.8.02.37.PM.mov

@thesahindia thesahindia requested a review from a team as a code owner February 23, 2022 14:49
@MelvinBot MelvinBot requested review from puneetlath and rushatgabhane and removed request for a team February 23, 2022 14:49
@thesahindia
Copy link
Member Author

thesahindia commented Feb 23, 2022

I have used the description that we already had as it was also in the mockup. Do we wanna use the description that was given in the issue?

Adding both here -

Given in the issue:-

       Restricted: 'Members of your workspace can find this room'
       Private: 'Only members explicitly invited can find this room'

Currently we are using:-

       Restricted: 'People in your workspace are able to find this room using Search',
       Private:  'Only people invited to this room are able to find it',

@puneetlath
Copy link
Contributor

I prefer the existing ones. @MitchExpensify what do you think?

@MitchExpensify
Copy link
Contributor

ha.. I'd lean toward a bit of a blend of both:

Restricted: People in your workspace can find this room
Private: People invited to this room can find it

Reason being I like them being a bit shorter, especially the Restricted description

@rushatgabhane
Copy link
Member

rushatgabhane commented Feb 24, 2022

Restricted: People in your workspace can find this room
Private: People invited to this room can find it

Asked for translations on slack just in case we go with the blend.

@iwiznia
Copy link
Contributor

iwiznia commented Feb 24, 2022

Hi!
Why are we removing using Search from the first one?

Anyway, if we want to make that change, the only thing we would need to change in the spanish translations is to remove a través de "Buscar". The rest should remain the same, as the meaning did not really change from what it was.

@puneetlath
Copy link
Contributor

I don't think the "using search" part is necessary for the description. It's just about who can find it. They don't need to know the mechanism for finding it.

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetlath LGTM!

@puneetlath puneetlath merged commit d780338 into Expensify:main Mar 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to staging by @puneetlath in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2022

🚀 Deployed to staging by @puneetlath in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Stutikuls
Copy link

Issue 1 -

Title- [Medium]: Chrome +Talkback: Screen reader : Focus stuck on the 'Visibility' control twice.
Actual - Focus lands on the Visibility control twice. first time its reading "Restricted" and 2nd time screen reader is reading "Visibility".
Expected - Focus should stay on the control only once and screen reader should read like "Visibility Restricted drop down button collapsed".
WCAG failure - 2.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7876_FOcus.stuck.twice.mp4

Issue 2 -

Title- [Medium]: Talkback+ Chrome: Screen reader : Incorrect role and state is defined for the 'Visibility' control.
Actual - When focus lands on the Visibility control then screen reader is reading "Restricted" and 2nd time screen reader is reading "Visibility" and focus lands on the label, value of the control individually.
Expected - Role = Drop down, State = Collapsed/expanded, Value = Restricted/private. Focus should land on the control only once and when focus lands on the control then screen reader should read like "Visibility Restricted drop down button collapsed".
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7876_Role.STate.is.not.defined.for.the.control.2.mp4

Issue 3 -

Title- [Medium]: Talkback+ Chrome: Screen reader :'Visibility' control drop down is not accessible using screen reader.
Actual - Visibility control is not accessible using screen reader.
Expected - 'Visibility' control drop down should accessible using screen reader.
WCAG failure - 2.1.1
Reproducible in staging?: - Yes
Version Number: - v1.1.44-3
Platforms - Android

7876_Visibilty.drop.down.is.not.accessible.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants