-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add informative text for visibility settings #7876
add informative text for visibility settings #7876
Conversation
I have used the description that we already had as it was also in the mockup. Do we wanna use the description that was given in the issue? Adding both here - Given in the issue:- Restricted: 'Members of your workspace can find this room'
Private: 'Only members explicitly invited can find this room' Currently we are using:- Restricted: 'People in your workspace are able to find this room using Search',
Private: 'Only people invited to this room are able to find it', |
I prefer the existing ones. @MitchExpensify what do you think? |
ha.. I'd lean toward a bit of a blend of both: Restricted: People in your workspace can find this room Reason being I like them being a bit shorter, especially the Restricted description |
Asked for translations on slack just in case we go with the blend. |
Hi! Anyway, if we want to make that change, the only thing we would need to change in the spanish translations is to remove |
I don't think the "using search" part is necessary for the description. It's just about who can find it. They don't need to know the mechanism for finding it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puneetlath LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @puneetlath in version: 1.1.41-0 🚀
|
🚀 Deployed to staging by @puneetlath in version: 1.1.41-0 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Issue 1 - Title- [Medium]: Chrome +Talkback: Screen reader : Focus stuck on the 'Visibility' control twice. 7876_FOcus.stuck.twice.mp4Issue 2 - Title- [Medium]: Talkback+ Chrome: Screen reader : Incorrect role and state is defined for the 'Visibility' control. 7876_Role.STate.is.not.defined.for.the.control.2.mp4Issue 3 - Title- [Medium]: Talkback+ Chrome: Screen reader :'Visibility' control drop down is not accessible using screen reader. 7876_Visibilty.drop.down.is.not.accessible.mp4 |
Details
Added informative text for visibiilty settings in New Room page
Fixed Issues
$ #7669
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2022-02-23.at.7.47.36.PM.mov
Mobile Web
Screen.Recording.2022-02-23.at.7.56.28.PM.mov
Desktop
Screen.Recording.2022-02-23.at.7.51.48.PM.mov
iOS
Screen.Recording.2022-02-23.at.8.05.36.PM.mov
Android
Screen.Recording.2022-02-23.at.8.02.37.PM.mov