Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the message that shows when trying to name a room using a name that already exists #7878

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

mateusbra
Copy link
Contributor

@mateusbra mateusbra commented Feb 23, 2022

Details

Fixed Issues

$ #7671

Tests | QA Steps

  1. Click "+"
  2. Click "New room"
  3. Type a name into the "Room name" field that is already used as a room name(#admins,#announce)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

WhatsApp Image 2022-02-23 at 16 18 26

Desktop

iOS

Android

image

@mateusbra mateusbra requested a review from a team as a code owner February 23, 2022 19:35
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team February 23, 2022 19:35
@pecanoro pecanoro merged commit 308e11f into Expensify:main Feb 23, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to staging by @pecanoro in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2022

🚀 Deployed to staging by @pecanoro in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora
Copy link

SumitDiyora commented Mar 21, 2022

Issue 1 -

Title- [Medium] Chrome+JAWS: Form field 'Room name' is not associated with their visible label.
Actual - The 'Room value' field is not announced with their visible labels.
Screen reader only read the value of the Room name, not reading the Label 'Room name' along with the value.
Expected -The visible label of a form field is programmatically associated with its form field so that assistive technology announces the label with the form field.
Screen reader should read like "Abc room name editable text box".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android

7878_form.field.not.associated.with.label.mp4

Issue 2 -

Title- [Medium] Chrome+Jaws: 'Room Name' text edit field is not marked as required and announced.
Actual - The fields 'Room name' text field is required to be filled but is not announced as required and no visual '' sign for the required field.
Screen reader only read the value of the Room name, not reading the Label 'Room name' along with the value.
Expected -If the form element is required, it should be announced as such for the screen reader users and a visual '
' sign for the required field should be there. Screen reader should read like "Abc room name editable text box".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android

7878_No.required.visual.indiction.has.been.given.for.fields.mp4

Issue 3 -

Title-[Medium] Chrome+Jaws: Screen reader: Error message is not announced by the screen reader.
Actual - Screen reader does not announce any inline error message appearing below to text boxes.
Expected - Inline error message should be conveyed to the users as soon as it appears on the fields so that the user can resolve the error.
WCAG failure - 3.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android

7878_error.messages.are.not.announced.mp4

Issue 4 -

Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for error message text.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on error message text (which becomes available when fields are empty). For instance, the #FC3826 "Please enter a room name" and "Please select a workspace" text has an insufficient color contrast ratio of 3.7.1 with a #FFFFFF background.
Expected - The "Please enter a room name" and "Please select a workspace" error message text should have a contrast ratio against the page background of 4.5:1 or greater.
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.

#7878_Insufficient color contrast for error message text

Issue 5 -

Title - [Medium]: Chrome: Insufficient color contrast for form controls.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on the screen. For instance, the #ECECEC border of "Room Name", "Workspace" and "Visibility" form fields has a contrast ratio of 1.2:1 with the #FFFFFF background.
Expected - The border of the input field should have a contrast ratio against the page background of 3:1 or greater.
WCAG failure - 1.4.11
Reproducible in staging? - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android
Suggested Fix - Ensure that the color contrast for all user interface controls in their default as well as active, hover, and focus states is 3:1 with the adjacent content.

#7826_Color contrast for form field

Issue 6 -

Title - [High]: Chrome+Jaws: Screen reader: Role is not defined for 'Create Room' control.
Actual - Role is not defined for the "Create Room" control. This made it difficult for screen reader users to access the functionality associated with it.
Expected - Role should be defined as a 'button' for the "Create Room" control.
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android
Suggested Fix - Ensure that all the page functionality is available for all users irrespective of the device being used.
Apply the following changes:

  • Specify role="button" for the 'div' element containing the "Create Room" control.

#7878_Role not defined for create room control

Issue 7 -

Title - [Medium] Chrome: Color Contrast: Insufficient color contrast for 'Create Room' control.
Actual - Background/foreground color combinations with an insufficient contrast ratio was found on control. For instance, the #03D47C "Create Room" control text has an insufficient color contrast ratio of 2.0.1 with a #FFFFFF background.
Expected - The "Create Room" text control should have a contrast ratio against the page background of 4.5:1 or greater..
WCAG failure - 1.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.42-2
Platforms - Web, Desktop, Mobile-web, iOS, Android
Suggested Fix - Ensure that each text/background color combination presents a contrast ratio of at least 4.5:1.

#7878_Insufficient color contrast for create room button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants