Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switching Priority Mode with an active draft message from crashing app #7907

Merged
merged 11 commits into from
Mar 4, 2022
+19 −7
Merged

Fix switching Priority Mode with an active draft message from crashing app #7907

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b9199e1
fix crash
Feb 24, 2022
f3e59cb
always reorder when changing focus
Feb 24, 2022
89eb09c
fix fix
Feb 26, 2022
b88a9fa
add comments because it took me several tries
Feb 26, 2022
da4dc8a
revert removing reorder condition
Feb 26, 2022
edb7149
clean it up a bit
Feb 28, 2022
d69f3bd
factor in priorityMode switching
Feb 28, 2022
208d137
Merge branch 'main' into ckt_focus_fixDraft
Feb 28, 2022
28d0309
fix comment
Feb 28, 2022
88ea587
clarify
Feb 28, 2022
c9fcea4
clarify comment
Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix crash
  • Loading branch information
Kosuke Tseng committed Feb 24, 2022
commit b9199e1c41d9d0540d28c4dff4235ded9f137f4b
2 changes: 1 addition & 1 deletion src/pages/home/sidebar/SidebarLinks.js
View file
Original file line number Diff line number Diff line change
@@ -167,7 +167,7 @@ class SidebarLinks extends React.Component {
const recentReports = SidebarLinks.getRecentReports(nextProps);
const orderedReports = shouldReorder
? recentReports
: _.map(prevState.orderedReports,
: _.filter(prevState.orderedReports,
orderedReport => _.chain(recentReports)
.filter(recentReport => orderedReport.reportID === recentReport.reportID)
.first()