-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storybook build #7955
Fix storybook build #7955
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
|
cc @kidroca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well. Thanks for the fix @roryabraham!
Fix storybook build (cherry picked from commit ed1d130)
🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.41-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Details
Fixes failed web deploy: https://github.com/Expensify/App/runs/5380104817?check_suite_focus=true
Fixed Issues
$ n/a
Tests (dev)
npm run storybook
– it should work!npm run storybook-build
– it should work!PR Review Checklist
Contributor (PR Author) Checklist
main
before submitting my PR for review### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madePR Reviewer Checklist
main
before submitting the PR### Fixed Issues
section abovesrc/languages/*
files (if applicable)QA Steps (staging)
Tested On
Web (Storybook) only
Screenshots
Web