Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Stg] Add title and artifactName back in ElectronBuilder config #7996

Merged
merged 3 commits into from
Mar 4, 2022
Merged

[CP Stg] Add title and artifactName back in ElectronBuilder config #7996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be83700
Add title and artifactName back
roryabraham Mar 4, 2022
ad4739a
Get rid of unnecessary directory
roryabraham Mar 4, 2022
2cf5210
Set app name in app menu
roryabraham Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...electronBuilder/electronBuilder.config.js → config/electronBuilder.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const {version} = require('../../package.json');
const {version} = require('../package.json');

const isStaging = process.env.ELECTRON_ENV === 'staging';
const isPublishing = process.argv.includes('--publish');
Expand Down Expand Up @@ -26,6 +26,8 @@ module.exports = {
type: 'distribution',
},
dmg: {
title: 'New Expensify',
artifactName: 'NewExpensify.dmg',
internetEnabled: true,
},
publish: [{
Expand Down
2 changes: 2 additions & 0 deletions desktop/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const CONFIG = require('../src/CONFIG').default;

const port = process.env.PORT || 8080;

app.setName('New Expensify');

/**
* Electron main process that handles wrapping the web application.
*
Expand Down
2 changes: 1 addition & 1 deletion desktop/notarize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const {notarize} = require('electron-notarize');
const electron = require('../config/electronBuilder/electronBuilder.config');
const electron = require('../config/electronBuilder.config');

exports.default = function notarizing(context) {
const {electronPlatformName, appOutDir} = context;
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-desktop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ info ""
title "Building Desktop App Archive Using Electron"
info ""
shift 1
"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder/electronBuilder.config.js "$@"
"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder.config.js "$@"