-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ROOT/api
to avoid ngrok problems
#8049
Use ROOT/api
to avoid ngrok problems
#8049
Conversation
yep, works well on dev. Nice ! |
Not sure whether I'm supposed to check all the boxes for this PR, but if I do I can continue tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.1.42-0 🚀
|
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
@marcaaron
Would this change resolve the ngrok problem?
Details
Trying to keep the same NetInfo config for dev and prod so that offline mode is detected the same way on both
Fixed Issues
$ #8043 (comment)
Tests
verify internet reachability url is used and the request is receiving response (when online)
internetReachability.js
ROOT/api
using together with ngrok should work
turning off network (airplane mode) should still correctly detect that you're offline
PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)QA Steps
Try to simulate very poor or no network conditions
Screenshots
Web
Mobile Web
Desktop
iOS
Android