[Fix] Prevent fade on scroll #8386

mdneyazahmad · 2022-03-31T07:11:59Z

Details

This pr fixes the touchable opacity animation which triggers when user is scrolling with chats and not pressing it.

Fixed Issues

$ #7596

Tests (Touch enabled devices eg: Native, mWeb, touchscreen laptop)

Open any chat with images.
Click on the image and scroll.
Verify that it does not fade when scrolls.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps (Touch enabled devices eg: Native, mWeb, touchscreen laptop)

Open any chat with images.
Click on the image and scroll.
Verify that it does not fade when scrolls.

Verify that no errors appear in the JS console

Screenshots

Web

web.mp4

Mobile Web

mweb.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

rushatgabhane

@mdneyazahmad I think we should rename this file since it isn't usingTouchable anymore.

Btw, are you sure we need pressAndBlur() method? Does Pressable also capture focus?
If no, we can remove this component entirely.

mdneyazahmad · 2022-04-04T04:26:43Z

@rushatgabhane I am not sure why we explicitly blur. I think we can remove that component and the changes will be

// file ImageRenderer.js
<AttachmentModal
            sourceURL={source}
            isAuthTokenRequired={isAttachment}
            originalFileName={originalFileName}
        >
            {({show}) => (
+               <Pressable onPress={show}>
                    <ThumbnailImage
                        previewSourceURL={previewSource}
                        style={styles.webViewStyles.tagStyles.img}
                        isAuthTokenRequired={isAttachment}
                    />
+               </Pressable>
            )}
        </AttachmentModal>

rushatgabhane · 2022-04-05T10:51:29Z

@mdneyazahmad sounds good!

mdneyazahmad · 2022-04-06T10:44:09Z

Updated

rushatgabhane

I am not sure why we explicitly blur

@mdneyazahmad Sorry for not noticing it earlier, but we'll be introducing a regression if we remove the blur.

So let's add back TouchableWithoutFocus and fix the merge conflicts.

mdneyazahmad · 2022-04-11T01:43:17Z

@rushatgabhane Thanks for finding this tricky issue.

mdneyazahmad · 2022-04-11T01:53:26Z

Should we rename it from TouchableWithoutFocus to PressabeWithoutFocus?

rushatgabhane · 2022-04-11T11:02:10Z

@mdneyazahmad yess. I'd also add a comment explaining or linking to the issue

mdneyazahmad · 2022-04-11T14:01:19Z

Updated

rushatgabhane

Thanks for the changes, LGTM! 🎉

The tests only apply to devices with a touchscreen, so please update them to mention that.
Also, please address the comment below. Thanks again!

rushatgabhane · 2022-04-12T19:49:36Z

src/components/PressableWithoutFocus.js

+        // We need to blur this element when clicked as it opens modal that implements focus-trapping.
+        // When the modal is closed it focuses back to the last active element.
+        // Therefore it shifts the element to bring it back to focus.
+        // https://github.com/Expensify/App/issues/6806


NAB: @mdneyazahmad please move this comment above the class PressableWithoutFocus

rushatgabhane · 2022-04-12T19:49:39Z

src/components/PressableWithoutFocus.js

@@ -23,27 +23,32 @@ const defaultProps = {
 /**
 * This component prevents the tapped element from capturing focus


src/components/PressableWithoutFocus.js

mdneyazahmad · 2022-04-13T10:52:54Z

@rushatgabhane done

rushatgabhane

@chiragsalian LGTM! 🎉
PressableWithoutFocus isn't a functional component because it's using a ref

#### PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

rushatgabhane · 2022-04-14T15:05:33Z

The tests only apply to devices with a touchscreen, so please update them to mention that

@mdneyazahmad gentle bump to update the Tests and QA steps to mention this.

mdneyazahmad · 2022-04-14T15:49:15Z

I missed that comment sorry for that @rushatgabhane

chiragsalian

LGTM 👍

OSBotify · 2022-04-14T17:41:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

rushatgabhane · 2022-04-14T17:49:06Z

The tests only apply to devices with a touchscreen, so please update them to mention that

@mdneyazahmad sorry that I wasn't clear enough. By touchscreen I don't mean to say Native only.

Web, and mWeb can have a touchscreen too 😄
So please update the issue to mention that these tests are applicable only for devices with a touchscreen (eg: Native, mWeb, touchscreen laptop)

mdneyazahmad · 2022-04-14T18:14:48Z

@rushatgabhane Thanks!

OSBotify · 2022-04-21T00:20:45Z

🚀 Deployed to staging by @chiragsalian in version: 1.1.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-04-25T22:20:07Z

🚀 Deployed to production by @francoisl in version: 1.1.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: prevent fade on scroll

32768de

mdneyazahmad requested a review from a team as a code owner March 31, 2022 07:12

melvin-bot bot requested review from chiragsalian and rushatgabhane and removed request for a team March 31, 2022 07:12

rushatgabhane reviewed Mar 31, 2022

View reviewed changes

rushatgabhane suggested changes Apr 8, 2022

View reviewed changes

mdneyazahmad added 3 commits April 11, 2022 16:41

refactor: rename component name

653dfcb

docs: update comments

bd51e48

resolve merge conflict

a8ce45a

rushatgabhane previously approved these changes Apr 12, 2022

View reviewed changes

rushatgabhane reviewed Apr 12, 2022

View reviewed changes

src/components/PressableWithoutFocus.js Outdated Show resolved Hide resolved

refactor: change variable name

258fd3c

mdneyazahmad dismissed rushatgabhane’s stale review via 258fd3c April 13, 2022 10:35

style: move comments above class

d01b810

rushatgabhane approved these changes Apr 14, 2022

View reviewed changes

chiragsalian approved these changes Apr 14, 2022

View reviewed changes

chiragsalian merged commit 2515b53 into Expensify:main Apr 14, 2022

chiragsalian assigned mdneyazahmad Apr 14, 2022

yuwenmemon mentioned this pull request Apr 20, 2022

Deploy Checklist: New Expensify 2022-04-20 #8707

Closed

54 tasks

melvin-bot bot mentioned this pull request Apr 25, 2022

[HOLD for payment 2022-05-02] [$1000] When you tap on any image/attachment and scroll, it fades - Reported by @mdneyazahmad #7596

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Prevent fade on scroll #8386

[Fix] Prevent fade on scroll #8386

mdneyazahmad commented Mar 31, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

mdneyazahmad commented Apr 4, 2022

rushatgabhane commented Apr 5, 2022

mdneyazahmad commented Apr 6, 2022

rushatgabhane left a comment •

edited

Loading

mdneyazahmad commented Apr 11, 2022

mdneyazahmad commented Apr 11, 2022

rushatgabhane commented Apr 11, 2022 •

edited

Loading

mdneyazahmad commented Apr 11, 2022

rushatgabhane left a comment •

edited

Loading

rushatgabhane Apr 12, 2022

rushatgabhane Apr 12, 2022

mdneyazahmad commented Apr 13, 2022

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Apr 14, 2022

mdneyazahmad commented Apr 14, 2022

chiragsalian left a comment

OSBotify commented Apr 14, 2022

rushatgabhane commented Apr 14, 2022

mdneyazahmad commented Apr 14, 2022

OSBotify commented Apr 21, 2022

OSBotify commented Apr 25, 2022

		@@ -23,27 +23,32 @@ const defaultProps = {
		/**
		* This component prevents the tapped element from capturing focus

[Fix] Prevent fade on scroll #8386

[Fix] Prevent fade on scroll #8386

Conversation

mdneyazahmad commented Mar 31, 2022 • edited Loading

Details

Fixed Issues

Tests (Touch enabled devices eg: Native, mWeb, touchscreen laptop)

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps (Touch enabled devices eg: Native, mWeb, touchscreen laptop)

Screenshots

Web

Mobile Web

Desktop

iOS

Android

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

mdneyazahmad commented Apr 4, 2022

rushatgabhane commented Apr 5, 2022

mdneyazahmad commented Apr 6, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

mdneyazahmad commented Apr 11, 2022

mdneyazahmad commented Apr 11, 2022

rushatgabhane commented Apr 11, 2022 • edited Loading

mdneyazahmad commented Apr 11, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane Apr 12, 2022

Choose a reason for hiding this comment

rushatgabhane Apr 12, 2022

Choose a reason for hiding this comment

mdneyazahmad commented Apr 13, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

#### PR Reviewer Checklist

rushatgabhane commented Apr 14, 2022

mdneyazahmad commented Apr 14, 2022

chiragsalian left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 14, 2022

rushatgabhane commented Apr 14, 2022

mdneyazahmad commented Apr 14, 2022

OSBotify commented Apr 21, 2022

OSBotify commented Apr 25, 2022

mdneyazahmad commented Mar 31, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Apr 11, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading