Commenting out the confimation modal to test something in staging. #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sketchydroide
added
Internal
tgolen
approved these changes
May 5, 2022
|
Triggered auto assignment to @iwiznia ( |
|
@tgolen looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
Merging with the linter failing because this is just going to be reverted shortly after we test it on staging. |
8 tasks
89 tasks
OSBotify
pushed a commit
that referenced
this pull request
May 6, 2022
…orkspace Commenting out the confimation modal to test something in staging. (cherry picked from commit c0f2264)
OSBotify
added a commit
that referenced
this pull request
May 6, 2022
…ging-8882 🍒 Cherry pick PR #8882 to staging 🍒
|
🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @tgolen
Details
We are removing the confirmation modal to see if we can figuring out why #8791 is happening
Fixed Issues
Does not really fix anything but will probably allows us to fix
Tests
N/A
QA Steps
(me @sketchydroide, os someother MobileDeployer will test this)
Screenshots
N/A